Jump to content

Pull Request: CInterface Update


Recommended Posts

Pull request: https://github.com/GarageGames/Torque3D/pull/2136

Branch: https://github.com/lukaspj/Torque3D/tree/cinterface-update


The PR seeks to update the CInterface, which was left in order to integrate JavaScript with T3D.


My main issues with the existing solution was that it still used the TorqueScript console for method calls, which is inefficient compared to calling functions directly. Also it didn't really work any more.

Furthermore, this CInterface seeks to transfer the control of method-lookups and the like from the console to the script that interfaces with the engine.


Main issues that needs to be addressed:


Script->Cinterface calls

In the codeInterpreter.cpp, TorqueScript calls the CInterface, this code should be reviewed / verified:

https://github.com/GarageGames/Torque3D/pull/2136/files#diff-5ec52f3c77bc47c45a6b93b21c6f783b


In console.cpp, the CInterface is called before the console is inquired about evaluation of the function call. This should be reviewed / verified:

https://github.com/GarageGames/Torque3D/pull/2136/files#diff-03ce4e39e998227a38fd95067262f6ad



Cinterface->Engine calls

In engineTypes.h, the ValueType of EngineStructTypeTraits has been changed, despite the fact there was a clear reason that it had the original type to begin with. This should be reviewed / verified:

https://github.com/GarageGames/Torque3D/pull/2136/files#diff-da7328c8cb002a64b343c49c865a5cc6

Link to post
Share on other sites

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
×
  • Create New...