LukasPJ Posted January 17, 2018 Share Posted January 17, 2018 Pull request: https://github.com/GarageGames/Torque3D/pull/2136Branch: https://github.com/lukaspj/Torque3D/tree/cinterface-updateThe PR seeks to update the CInterface, which was left in order to integrate JavaScript with T3D.My main issues with the existing solution was that it still used the TorqueScript console for method calls, which is inefficient compared to calling functions directly. Also it didn't really work any more.Furthermore, this CInterface seeks to transfer the control of method-lookups and the like from the console to the script that interfaces with the engine.Main issues that needs to be addressed:Script->Cinterface callsIn the codeInterpreter.cpp, TorqueScript calls the CInterface, this code should be reviewed / verified:https://github.com/GarageGames/Torque3D/pull/2136/files#diff-5ec52f3c77bc47c45a6b93b21c6f783bIn console.cpp, the CInterface is called before the console is inquired about evaluation of the function call. This should be reviewed / verified:https://github.com/GarageGames/Torque3D/pull/2136/files#diff-03ce4e39e998227a38fd95067262f6adCinterface->Engine callsIn engineTypes.h, the ValueType of EngineStructTypeTraits has been changed, despite the fact there was a clear reason that it had the original type to begin with. This should be reviewed / verified:https://github.com/GarageGames/Torque3D/pull/2136/files#diff-da7328c8cb002a64b343c49c865a5cc6 Quote Link to comment Share on other sites More sharing options...
Recommended Posts
Join the conversation
You can post now and register later. If you have an account, sign in now to post with your account.