Jump to content

Recommended Posts

Posted (edited)

Ran into another problem I managed to fix. If this isn't the right forums for posts like these, or if I should be doing this on github, please let me know.

Anyways, the simgroup/simset function callOnChildren wasn't working, so I changed

void SimSet::callOnChildren(simSet.cpp line 232)
{
...
  ConsoleValueRef args[21];
  args[0] = method.c_str();

to this

	ConsoleValue vals[2];
ConsoleValueRef args[21];
vals[0].init();
vals[0].setStringValue(method.c_str());
args[0].value = &vals[0];
vals[1].init();
args[1].value = &vals[1];

and things started to work again. Was that the right way to go about it?

Edited by newaged
Posted

Was it causing a crash? I stopped using the callOnChildren after it caused too much crash, also if I remember right it was not always working correctly when it wasn't causing crash...

Posted
Was it causing a crash? I stopped using the callOnChildren after it caused too much crash, also if I remember right it was not always working correctly when it wasn't causing crash...

Yeah, it was causing a crash before. I haven't used it enough to comment on the second problem.

Posted

Yeah, if you feel you have a useful addition or fix, feel free to toss it up onto github. Bit easier to test/review it that way, but also feel free to make a thread bringing attention to it :)


I'll have to give this fix a go. I don't REMEMBER having problems with callOnChildren, but then, I haven't used it a ton.

Posted

Updated the code - removed some pointless changes


@JeffR I'll look into posting these fixes on github. Should they be batched together or done individually?

Posted

fwiw, PRs with a given task show up when checking a files history on the github website so that'd help folks understand the why on changes. Least that's the personal rule of thumb...

Join the conversation

You can post now and register later. If you have an account, sign in now to post with your account.

Guest
Reply to this topic...

×   Pasted as rich text.   Paste as plain text instead

  Only 75 emoji are allowed.

×   Your link has been automatically embedded.   Display as a link instead

×   Your previous content has been restored.   Clear editor

×   You cannot paste images directly. Upload or insert images from URL.

×
×
  • Create New...